Skip to content

Increase Dial retry timeout from 10s to 30s#542

Merged
mangelajo merged 1 commit intomainfrom
fix/increase-dial-retry-timeout
Apr 13, 2026
Merged

Increase Dial retry timeout from 10s to 30s#542
mangelajo merged 1 commit intomainfrom
fix/increase-dial-retry-timeout

Conversation

@ambient-code
Copy link
Copy Markdown
Contributor

@ambient-code ambient-code bot commented Apr 10, 2026 •
edited by mangelajo
Loading

Summary

  • Increases server-side Dial retry maxTotalWait from 10s to 30s in controller_service.go:657
  • Aligns the server-side retry window with the client-side dial_timeout default (30s)
  • Fixes the E2E flake where exporters in CI take >10s to transition from Available to LeaseReady, causing repeated Dial rejections and eventual context cancellation

Fixes #538

Test plan

  • Verify the change compiles (go build / go vet pass — confirmed locally)
  • CI E2E tests should pass without the Dial rejection flake
  • Confirm no regression in Dial behavior for non-transient exporter statuses (Offline, HookFailed still fail immediately)

🤖 Generated with Claude Code

@claude
Increase Dial retry timeout from 10s to 30s to fix E2E flake
3faeb2d 
The server-side Dial retry window (10s) was too short for CI environments
where the exporter may take longer to transition from Available to
LeaseReady status. This caused repeated Dial rejections and eventual
context cancellation in E2E tests. Increasing to 30s aligns the
server-side retry with the client-side dial_timeout default.

Fixes #538

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ambient-code ambient-code bot mentioned this pull request Apr 10, 2026
Closed
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 10, 2026

❌ Deploy Preview for jumpstarter-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 3faeb2d
🔍 Latest deploy log https://app.netlify.com/projects/jumpstarter-docs/deploys/69d94739ac9f4e000857c367

@mangelajo mangelajo mentioned this pull request Apr 13, 2026
Closed
2 tasks
@mangelajo
Copy link
Copy Markdown
Member

mangelajo commented Apr 13, 2026

Let's see if this really has en effect, I suspect that the exporters are not coming back online after some situations. But this won't hurt.

@mangelajo mangelajo enabled auto-merge (rebase) April 13, 2026 08:03
@mangelajo mangelajo merged commit f473ede into main Apr 13, 2026
37 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mangelajo mangelajo mangelajo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

E2E test failure: Dial rejected with Available status despite server-side retry fix

1 participant

@mangelajo